Dist diagonal #120
Closed
Dist diagonal #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datseris
requested changes
Mar 30, 2023
Comment on lines
+124
to
+126
| average_displacement(x, τ, m) -> S_m(τ) | ||
| Determines the average displacement from the diagonal generalized SSR given a τ. | ||
| Adapted from: https://www.delucafoundation.org/download/bibliography/de-luca/061.pdf. |
There was a problem hiding this comment.
What is SSR? Please expand it fully and avoid abbreviations.
Additionally, please properly cite the actual paper using the syntax that is used in the rest of the docstrings. [^Rosenstein1993].
| @@ -13,14 +13,15 @@ diffeq = (atol = 1e-9, rtol = 1e-9) | |||
| @test exponential_decay_fit(x, y, :small) ≈ 5 | |||
|
|
|||
| henon_rule(x, p, n) = SVector(1.0 - p[1]*x[1]^2 + x[2], p[2]*x[1]) | |||
| ds = DeterministicIteratedMap(henon_rule, zeros(2), [1.4, 0.3]) | |||
| ds = DiscreteDynamicalSystem(henon_rule, zeros(2), [1.4, 0.3]) | |||
| data = trajectory(ds, 1000)[1] | ||
| data = trajectory(ds, 1000)#[1] |
There was a problem hiding this comment.
This is an odd change... You are going from DynamicalSystems.jl v3 to v2? Why? No regressions should happen in this PR. Please update your local code to DYnamicalSystems.jl v3 and adjust accordingly.
|
|
||
| Method requires the embedding dimension as arg m. | ||
| """ | ||
| function average_displacement(x::Vector, τ::Int; m::Int=7) |
There was a problem hiding this comment.
Does x have to be a Vector? I think it can be AbstractVector instead.
|
Bump @denizhanpak |
1 similar comment
|
Bump @denizhanpak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I think I implemented this right and tested it. I ran into an issue with dynamical systems base where CoupledODEs couldn't be found so couldn't add a test for that case. Also this is my first time contributing so if I am missing steps please let me know.