Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HolidayCalendarCache is not type stable #43

Open
SleepingPills opened this issue Mar 30, 2020 · 0 comments
Open

HolidayCalendarCache is not type stable #43

SleepingPills opened this issue Mar 30, 2020 · 0 comments
Assignees
@felipenoris
Milestone
v1.0

Comments

@SleepingPills
Copy link

The HolidayCalendarCache as implemented is not type stable due to the hc field being of abstract type HolidayCalendar. This then causes unnecessary allocations and is a degrades performance.

I suppose either the HCC struct should be made generic - parametrized on the type of calendar it holds.
@felipenoris felipenoris added this to the v1.0 milestone Apr 17, 2020
@felipenoris felipenoris self-assigned this Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipenoris felipenoris

Labels
None yet
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@SleepingPills @felipenoris