Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy between listbdays and bdays/bdayscount #66

Open
tbeason opened this issue Aug 9, 2024 · 1 comment
Open

Discrepancy between listbdays and bdays/bdayscount #66

tbeason opened this issue Aug 9, 2024 · 1 comment

Comments

@tbeason
Copy link

tbeason commented Aug 9, 2024

I sort of expected consistency between these two functions. Should probably add some clarification to the bdays and bdayscount functions to indicate the "counting convention"?

julia> listbdays(:USNYSE,Date(2024,3,28),Date(2024,4,26))
21-element Vector{Date}:
 2024-03-28
 2024-04-01
 2024-04-02
 2024-04-03
 2024-04-04
 2024-04-05
 2024-04-08
 2024-04-09
 2024-04-10
 2024-04-11
 2024-04-12
 2024-04-15
 2024-04-16
 2024-04-17
 2024-04-18
 2024-04-19
 2024-04-22
 2024-04-23
 2024-04-24
 2024-04-25
 2024-04-26

julia> bdayscount(:USNYSE,Date(2024,3,28),Date(2024,4,26))
20
@felipenoris
Copy link
Collaborator

Good point. Never thought about this when I coded listbdays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants