Update SPIRVIntrinsics from 0.2 to 0.5 (#542)

* NEO v25.35.35096
* Fixes for SPIRVIntrinsics 0.5
* Add div(::Float32, ::Float32) override

Author: michel2323

Project.toml

@@ -1,7 +1,7 @@
 name = "oneAPI"
 uuid = "8f75cd03-7ff8-4ecb-9b8f-daf728133b1b"
 authors = ["Tim Besard <[email protected]>"]
-version = "2.4.0"
+version = "2.4.1"
 
 [deps]
 AbstractFFTs = "621f4979-c628-5d54-868e-fcf4e3e8185c"
@@ -37,18 +37,19 @@ Adapt = "4"
 CEnum = "0.4, 0.5"
 ExprTools = "0.1"
 GPUArrays = "11.2.1"
-GPUCompiler = "1.5"
+GPUCompiler = "1.6"
 GPUToolbox = "0.1, 0.2, 0.3, 1"
 KernelAbstractions = "0.9.1"
 LLVM = "6, 7, 8, 9"
-NEO_jll = "=25.31.34666"
+NEO_jll = "=25.35.35096"
 Preferences = "1"
-SPIRVIntrinsics = "0.2"
-SPIRV_LLVM_Translator_jll = "20"
+SPIRVIntrinsics = "0.5"
+SPIRV_LLVM_Translator_jll = "21"
+SPIRV_Tools_jll = "2025.4.0"
 SpecialFunctions = "1.3, 2"
 StaticArrays = "1"
 julia = "1.10"
-oneAPI_Level_Zero_Loader_jll = "1.22"
+oneAPI_Level_Zero_Loader_jll = "1.24"
 oneAPI_Support_jll = "0.9.2"
 
 [extras]

README.md

@@ -147,7 +147,7 @@ translator](https://github.com/KhronosGroup/SPIRV-LLVM-Translator):
 
 ```julia
 julia> function kernel()
-         barrier()
+         barrier(0)
          return
        end
 

src/array.jl

@@ -279,8 +279,8 @@ end
 
 ## interop with GPU arrays
 
-function Base.unsafe_convert(::Type{oneDeviceArray{T,N,AS.Global}}, a::oneArray{T,N}) where {T,N}
-  oneDeviceArray{T,N,AS.Global}(size(a), reinterpret(LLVMPtr{T,AS.Global}, pointer(a)),
+function Base.unsafe_convert(::Type{oneDeviceArray{T,N,AS.CrossWorkgroup}}, a::oneArray{T,N}) where {T,N}
+  oneDeviceArray{T,N,AS.CrossWorkgroup}(size(a), reinterpret(LLVMPtr{T,AS.CrossWorkgroup}, pointer(a)),
                                 a.maxsize - a.offset*Base.elsize(a))
 end
 

src/compiler/compilation.jl

@@ -6,15 +6,17 @@ const oneAPICompilerJob = CompilerJob{SPIRVCompilerTarget,oneAPICompilerParams}
 
 GPUCompiler.runtime_module(::oneAPICompilerJob) = oneAPI
 
-GPUCompiler.method_table(::oneAPICompilerJob) = method_table
+GPUCompiler.method_table_view(job::oneAPICompilerJob) =
+    GPUCompiler.StackedMethodTable(job.world, method_table, SPIRVIntrinsics.method_table)
 
 # filter out OpenCL built-ins
 # TODO: eagerly lower these using the translator API
 GPUCompiler.isintrinsic(job::oneAPICompilerJob, fn::String) =
     invoke(GPUCompiler.isintrinsic,
            Tuple{CompilerJob{SPIRVCompilerTarget}, typeof(fn)},
            job, fn) ||
-    in(fn, opencl_builtins)
+    in(fn, known_intrinsics) ||
+    contains(fn, "__spirv_")
 
 function GPUCompiler.finish_module!(job::oneAPICompilerJob, mod::LLVM.Module,
                                     entry::LLVM.Function)

src/compiler/execution.jl

@@ -88,7 +88,7 @@ Adapt.adapt_storage(to::KernelAdaptor, p::ZePtr{T}) where {T} = reinterpret(Ptr{
 
 # convert oneAPI host arrays to device arrays
 Adapt.adapt_storage(::KernelAdaptor, xs::oneArray{T,N}) where {T,N} =
-  Base.unsafe_convert(oneDeviceArray{T,N,AS.Global}, xs)
+  Base.unsafe_convert(oneDeviceArray{T,N,AS.CrossWorkgroup}, xs)
 
 # Base.RefValue isn't GPU compatible, so provide a compatible alternative.
 # TODO: port improvements from CUDA.jl

src/device/quirks.jl

@@ -60,10 +60,13 @@ end
 
 # From Metal.jl to avoid widemul and Int128
 @static if VERSION >= v"1.12.0-DEV.1736" # Partially reverts JuliaLang/julia PR #56750
-    let BitInteger64 = Union{Int64, UInt64}
-        @device_override function Base.checkbounds(::Type{Bool}, v::StepRange{<:BitInteger64, <:BitInteger64}, i::BitInteger64)
-            @inline
-            return checkindex(Bool, eachindex(IndexLinear(), v), i)
-        end
+    const BitInteger64 = Union{Int64, UInt64}
+    @device_override function Base.checkbounds(::Type{Bool}, v::StepRange{<:BitInteger64, <:BitInteger64}, i::BitInteger64)
+        @inline
+        return checkindex(Bool, eachindex(IndexLinear(), v), i)
     end
+
+    # Less accurate division for Float32 than Base Julia which relies on Float64
+    # https://github.com/JuliaLang/julia/pull/49637
+    @device_override Base.div(x::Float32, y::Float32) = trunc(x / y)
 end

src/mapreduce.jl

@@ -16,7 +16,7 @@
     # perform a reduction
     d = 1
     while d < items
-        barrier()
+        barrier(0)
         index = 2 * d * (item-1) + 1
         @inbounds if index <= items
             other_val = if index + d <= items

src/oneAPI.jl

@@ -30,6 +30,7 @@ functional() = oneL0.functional[]
 import SPIRVIntrinsics
 SPIRVIntrinsics.@import_all
 SPIRVIntrinsics.@reexport_public
+Base.Experimental.@MethodTable(method_table)
 include("device/runtime.jl")
 include("device/array.jl")
 include("device/quirks.jl")

src/oneAPIKernels.jl

@@ -1,7 +1,7 @@
 module oneAPIKernels
 
 using ..oneAPI
-using ..oneAPI: @device_override
+using ..oneAPI: @device_override, SPIRVIntrinsics, method_table
 
 import KernelAbstractions as KA
 
@@ -161,7 +161,7 @@ end
 ## Synchronization and Printing
 
 @device_override @inline function KA.__synchronize()
-    barrier()
+    barrier(0)
 end
 
 @device_override @inline function KA.__print(args...)

test/device/intrinsics.jl

@@ -226,7 +226,7 @@ end
 
         s[t] = d[t]
         s2[t] = 2*d[t]
-        barrier()
+        barrier(0)
         d[t] = s[tr]
 
         return
@@ -252,7 +252,7 @@ end
 
             s[t] = d[t]
             s2[t] = d[t]
-            barrier()
+            barrier(0)
             d[t] = s[tr]
 
             return