Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DURENDAL (8c2176b commit) method with Update-Then-Aggregate schema.
There is only one challenge with the requirements. The DURENDAL code requires
torch_geometric_temporal==0.54.0
which needspandas==1.3.5
, however, our pandas version in TGB ispandas==1.5.3
. Downgrading to 1.3.5 will cause problem with reading pickle fileml_{data}.pkl
because the file is created using pandas 1.5.3. My workaround to test the code was to export the file using pandas 1.3.5. We can also try using pd.read_pickle as mentioned here. I didn't change the code in the base to avoid any issues with other parts.Now that I have the code structure, I think adopting other methods and baselines from DURENDAL code base should be relatively easier. I will try to work on it if I got time.