-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[meta-issue] State of examples #137
Comments
Randy thanks for making this! minesweeper.jl, is related to #122 |
I should add that I intended the current examples to be replaced by #67 . I haven't worked on it in a while |
Was going to hassle you about that, it's got merge conflicts ;)
|
There you go, I moved the non-doc commits which were causing the conflict to a new |
(I'm merging master and fixing things up now) |
Okay I have updated |
@shashi @randyzwitch any idea what is causing mc.jl to not work correctly? I have an app that uses a similar abstraction that exhibits the same behaviour. Sometimes the button fires and sometimes not. I noticed that it started acting this way around the time Reactive.jl v0.3 was tagged which deprecated Input() and lift() - not sure if there's any relation. I've tar'd up the last METADATA.jl that mc.jl worked with and it appears Reactive.jl was at version 0.2.4. This issue seems hard to pin down because it appears the button fires, but it gets held up once it hits the Reactive function calls - and if you refresh - sometimes the simulation will execute. Perhaps there was a breaking change from Reactive 0.2.4 to 0.3.0 (or maybe it's a Compose or Interact issue). It's almost as if Julia is still compiling the app while the UI is already being rendered. Sometimes if you wait after clicking the button for 30+ seconds I've seen it execute. |
For what it's worth: result = map(sampleon(btn, N); typ=Any, init=nothing) do n
# doesn't reach this point when the simulation doesn't fire
# despite the browser dev tools showing that the button is detected as clicked
println("fire!")
run_simulate(n, running, current_approx)
end Although again - it's a Heisenbug in that if you refresh repeatedly the simulation runs on occasion - which leads me to believe it's something with compilation |
Reactive 0.3+ uses channels, so the updates are asynchronous - so if you do a |
Running on 0.4.6 on OSX, I found the following:
boids.jl: Seems to work, WARNING: using Compose.px in module Main conflicts with an existing identifier.Naming clashes #41code-cell.jl: Seems to workform.jl: Seems to worklatex.jl: Part of [WIP] Fix examples to qualify pad as Escher.pad #136 (fixed pad, checkbox centers code)layout2.jl: Seems to workminesweeper.jl: Broken, don't know how to fix hbox not working properly #122plotting.jl: works, throws Gadfly.render warningNaming clashes #41recursive-layout.jl: works, throws Gadfly.render warningNaming clashes #41vectorgraphics.jl: Seems to workSo not bad, can fix up
latex.jl
andmc.jl
pretty quickly I'd think. Minesweeper doesn't lay out grid for me, it makes everything as rows (though the rows are interactive to spaces away from a mine)The text was updated successfully, but these errors were encountered: