Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MinNewTokensLengthLogitsProcessor #37

Open
wiseodd opened this issue Jul 1, 2024 · 0 comments
Open

Use MinNewTokensLengthLogitsProcessor #37

wiseodd opened this issue Jul 1, 2024 · 0 comments
Assignees
@wiseodd
Labels
enhancement New feature or request

Comments

@wiseodd
Copy link
Collaborator

wiseodd commented Jul 1, 2024

Instead of reimplementing eos suppressing mechanism from the above, let's just use that. As a bonus, it gives ULTS a min_new_tokens parameter => feature-parity with Huggingface.
@wiseodd wiseodd added the enhancement New feature or request label Jul 1, 2024
@wiseodd wiseodd self-assigned this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wiseodd wiseodd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wiseodd