make cat_disk run on a vector rather than a vararg

[asinghvi17]

Ideally this should allow us to run cat across a large number of arrays.

[felixcremer]

Shouldn't we rather implement Base.stack instead? From the docstring below it seems to me, that this is the function we aim for when we want to concatenate a list of DiskArrays:

  stack(iter; [dims])

  Combine a collection of arrays (or other iterable objects) of equal size into one larger array, by arranging them
  along one or more new dimensions.

[asinghvi17]

The key word there is new dimensions...the problem here was to cat along a preexisting one

[rafaqz]

I don't get what's achieved here, there's already a splat into the base function cat.

If your going to call a DiskArrays method anyway ConcatDiskArray already works how you want, even on multidimensional arrays, I suggest doing that. cat_disk is literally just cat for disk arrays, and it's internal. It's just defined separately so it's not stuck inside the macro

[asinghvi17]

Yeah, I had wondered if this might speed up the compilation a bit so tried it on my phone. Tested it and apparently try not :D

[rafaqz]

Where we could do this is with a reduce vcat hack that Base also has...

[asinghvi17]

Should we just use that method for combine on a stack as well then,