Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.4.10 was breaking #236

Open
felixcremer opened this issue Feb 19, 2025 · 6 comments
Open

0.4.10 was breaking #236

felixcremer opened this issue Feb 19, 2025 · 6 comments

Comments

@felixcremer
Copy link
Contributor

Unfortunately 0.4.10 was a breaking release, where at least the renaming of ChunkType to ChunkVector is breaking.
This broke DiskArrayTools see meggart/DiskArrayTools.jl#33.

I haven't checked what other breaking changes might have been included.
@rafaqz
Copy link
Collaborator

rafaqz commented Feb 19, 2025

Oh damn. Probably we need to be much more explicit about what is API as none of this is exported and most wasn't documented before that PR

@rafaqz
Copy link
Collaborator

rafaqz commented Feb 19, 2025

What's your proposed fix

@felixcremer
Copy link
Contributor Author

Good point. Maybe your right and it was not part of the API anyway. We should be explicit about what is public.

@felixcremer
Copy link
Contributor Author

I can have a look at DiskArrayTools and fix it there.

@rafaqz
Copy link
Collaborator

rafaqz commented Feb 19, 2025

Yeah breaking changes here mean a lot of work across the ecosystem, and probably DislArrayTools is pretty deep in internals.

Other option is to revert, bump a new patch and then revert again with a breaking change

@felixcremer
Copy link
Contributor Author

I reflected the current changes in DiskArrayTools. This shows, that we should have reverse dependency tests on DiskArrayTools because that is so intertwined with DiskArrays or we would need to move the useful code from there over to DiskArrays.
@meggart why is the split between DiskArrays and DiskArrayTools necessary?

vitorhirata added a commit to vitorhirata/ADRIA.jl that referenced this issue Feb 21, 2025
@vitorhirata
Pin DiskArrays to 0.4.9
bd1432b 
YAXArrays uses DiskArrays and it is raising an error in its last update.
See JuliaIO/DiskArrays.jl#236 for more
details. To solve the problem we add and pin DiskArrays version to
0.4.9.
vitorhirata added a commit to vitorhirata/ADRIA.jl that referenced this issue Feb 21, 2025
@vitorhirata
Pin DiskArrays to 0.4.n DiskArrays to 0.4.9
fd2a63d 
YAXArrays uses DiskArrays and it is raising an error in its last update.
See JuliaIO/DiskArrays.jl#236 for more details.
To solve the problem we add and pin DiskArrays version to
0.4.9.
It also updates the Manifest and ran tests to check the code is still
working.
vitorhirata added a commit to vitorhirata/ADRIA.jl that referenced this issue Feb 21, 2025
@vitorhirata
Pin DiskArrays to 0.4.9
323d65f 
YAXArrays uses DiskArrays and it is raising an error in its last update.
See JuliaIO/DiskArrays.jl#236 for more details. To solve the problem we
add and pin DiskArrays version to 0.4.9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rafaqz @felixcremer