Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alg is not a keyword argument #1208

Closed
araujoms opened this issue Feb 14, 2025 · 2 comments · Fixed by #1214
Closed

alg is not a keyword argument #1208

araujoms opened this issue Feb 14, 2025 · 2 comments · Fixed by #1214

Comments

@araujoms
Copy link
Contributor

When the argument alg was added to eigen and eigvals in JuliaLang/julia#49355 it was added as a positional argument, but the docstrings and error messages refer to it as a keyword argument. One could simply change them, but since svd has accepted an actual keyword argument alg since Julia 1.3, perhaps it is better to make the new one a keyword argument for consistency? That wouldn't break anything since Julia 1.12 is not yet released.

@jishnub
Copy link
Collaborator

jishnub commented Feb 15, 2025

This was the idea behind JuliaLang/julia#55481, although it didn't get merged in time. Perhaps I should resurrect it.

@araujoms
Copy link
Contributor Author

Please do, I think that would be the optimal solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants