You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The docs about DenseArray merely require that elements are stored contiguously in memory, so one could define a DenseArray subtype that meets that definition and does not define strides or pointer. In that case, the type would be a StridedArray because DenseArray <: StridedArray, but would not actually follow the StridedArray API.
I do not think it is reasonable for users to be expected to read the StridedArray docs when defining a DenseArray because StridedArray is simply a union that happens to contain DenseArray.
The docs about DenseArray merely require that elements are stored contiguously in memory, so one could define a DenseArray subtype that meets that definition and does not define
strides
orpointer
. In that case, the type would be a StridedArray because DenseArray <: StridedArray, but would not actually follow the StridedArray API.I do not think it is reasonable for users to be expected to read the StridedArray docs when defining a DenseArray because StridedArray is simply a union that happens to contain DenseArray.
https://docs.julialang.org/en/v1/base/arrays/#Core.DenseArray
https://docs.julialang.org/en/v1/base/arrays/#Base.StridedArray
https://docs.julialang.org/en/v1/manual/interfaces/#man-interface-strided-arrays
Originally posted by @LilithHafner in #54558 (comment)
The text was updated successfully, but these errors were encountered: