Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

methodtable total searches need to consider all binding partitions #57560

Open
vtjnash opened this issue Feb 27, 2025 · 0 comments
Open

methodtable total searches need to consider all binding partitions #57560

vtjnash opened this issue Feb 27, 2025 · 0 comments
Milestone

Comments

@vtjnash
Copy link
Member

vtjnash commented Feb 27, 2025

With the binding partition work, our various methodtable visitors (e.g. staticdata, ml_matches, disable_method, Test, REPLCompletions) might fail to correctly find all types and thus fail to find all methods as may be required for correctness. We need to update our many different copies of the methodtable visitor logic to look specifically at all BindingPartitions of all Bindings in all worlds and not to look at the output of names anymore to enumerate them.

This is also a possible bug for any other consumer of names (e.g. summarysize), though there are quite few of those uses currently in base and stdlib.

@vtjnash vtjnash added this to the 1.12 milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant