Support @opaque Tuple{T,U...}->RT (...)->... syntax for explicit arg/return types
#54947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
changed the title
opaque Tuple{T,U...}->RT (...)->... syntax for explicit arg/return types@opaque Tuple{T,U...}->RT (...)->... syntax for explicit arg/return types
topolarity
force-pushed
the
ct/opaque-closure-rt
branch
2 times, most recently
from
377b162
to
a4a5912
Compare
topolarity
commented
Jun 26, 2024
This provides a means to explicitly specify the return type of an OpaqueClosure, which previously was not possible without calling `jl_new_opaque_closure` directly. As a result, `@opaque AT (...)->...` is no longer an allowed form to define an OpaqueClosure. Instead `@opaque AT->_ (...)->...` should be used.
topolarity
force-pushed
the
ct/opaque-closure-rt
branch
3 times, most recently
from
3928aa1
to
cd74005
Compare
|
This should be ready for review again |
|
@Keno If there are no complaints, I plan to merge this tomorrow |
aviatesk
reviewed
Sep 3, 2024
| end | ||
| AT = (AT !== :_) ? AT : nothing | ||
| RT = (RT !== :_) ? RT : nothing | ||
| return esc(Expr(:opaque_closure, AT, RT, RT, ex)) |
There was a problem hiding this comment.
Shouldn't rt_lb be Union{} instead of RT?
There was a problem hiding this comment.
That would allow the optimizer to change the return type, but the purpose of this syntax is to guarantee that the optimizer won't change the type on you.
e.g. you need to generate an OpaqueClosure{Tuple{Int,Int},Int} because it will be put into a container - an OpaqueClosure{Tuple{Int,Int},Union{}} would be the wrong thing to generate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives users a way to explicitly specify the return type of an OpaqueClosure, and it also removes the old syntax
@opaque AT ...in preference of@opaque AT->_ ...