-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.9 extensions #52
1.9 extensions #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an amazing PR ❤️ thank you very much!
@longemen3000 tests are failing, can you please take a look? Also, is it possible to specify a compat entry for the weakdeps as well? |
yes! |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #52 +/- ##
==========================================
- Coverage 71.42% 68.22% -3.21%
==========================================
Files 15 18 +3
Lines 203 214 +11
==========================================
+ Hits 145 146 +1
- Misses 58 68 +10
|
@juliohm tests pass, and compat added. Some things pending (not related to the PR)
|
That is awesome @longemen3000 , thank you very much for working on it. It is really tricky to convert Requires.jl to extensions and this serves as a good example. I am wondering if there is something else we could do to avoid the verbosity of the if(isdefined(...)) else end blocks. Maybe we could define some macro to switch back and forth between Requires.jl and extensions? I can merge the PR as is without problems, just asking in case you have a quick idea. I find it strange that we need to repeat the if-else so many times and in so many different source files. |
there isn't at the moment haha, maybe in the future a package could provide such macro. For backwards compatibility, there is |
support for 1.9 extensions.
there are some changes:
Zygote
->ChainRulesCore
(more low level)CUArrays
->GPUArrays
(more general,CUArrays
is deprecated in favor ofCUDA
, that usesGPUArrays
)