Use PackageExtensionTools.jl

[juliohm]

Refactor the code to use https://github.com/cjdoris/PackageExtensionTools.jl

[longemen3000]

i would recommend to wait until the code is merged into Requires.jl

[juliohm]

@longemen3000 you mean that PackageExtensionTools.jl will be merged into Requires.jl?

[longemen3000]

i suppose, check JuliaPackaging/Requires.jl#114

[juliohm]

Can we use PackageExtensionTools.jl now on this package as an example? It seems that the Requires.jl PR was merged. Em ter., 30 de mai. de 2023 12:09, Andrés Riedemann < ***@***.***> escreveu:

…

i suppose, check JuliaPackaging/Requires.jl#114 <JuliaPackaging/Requires.jl#114> — Reply to this email directly, view it on GitHub <#55 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZQW3J4PK2C4KMS3M4FRE3XIYER3ANCNFSM6AAAAAAYS2LLNQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[juliohm]

@longemen3000 what is the status quo now for these extension packages?

[longemen3000]

Now that it is merged, it is possible to give it a try

[juliohm]

@longemen3000 can you kindly help here again converting the manual approach to the new recommended approach with PackageExtensionCompat.jl? Is that the newest recommended approach?

[longemen3000]

let me ask, the main problem in this particular package is that some extensions require 2 external packages loaded (JuMP + IPOPT, for example) i don't know if that package supports that specific workflow

[juliohm]

This package requires 2 packages as you described. Does it mean that we need to preserve the current approach? What if we drop support for Julia < 1.9, can we simplify the code organization? Em seg., 3 de jul. de 2023 17:00, Andrés Riedemann ***@***.***> escreveu:

…

let me ask, the main problem in this particular package is that some extensions require 2 external packages loaded (JuMP + IPOPT, for example) i don't know if that package supports that specific workflow — Reply to this email directly, view it on GitHub <#55 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZQW3NE3Q35NUI3M2UZCVLXOMQGNANCNFSM6AAAAAAYS2LLNQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[longemen3000]

cjdoris/PackageExtensionCompat.jl#7

[longemen3000]

if you drop julia < 1.9, then you can drop requires too

[juliohm]

@longemen3000 could you help with a quick PR that drops Julia < v1.9 support? I will try to read the package extensions docs by the end of the week, but I am assuming that this specific case with DensityRatioEstimation.jl and its optional functionality that depends on multiple packages is a tricky case to get right.

[longemen3000]

wait a moment, i'll do it right now

[juliohm]

Fixed on master.