Skip to content
This repository has been archived by the owner on May 23, 2022. It is now read-only.

Drop support to Julia v1.0? #37

Closed
juliohm opened this issue Apr 14, 2020 · 3 comments
Closed

Drop support to Julia v1.0? #37

juliohm opened this issue Apr 14, 2020 · 3 comments
Labels
question

Comments

@juliohm
Copy link
Member

juliohm commented Apr 14, 2020

The build fails in Julia v1.0. What should we do about it? https://travis-ci.org/github/JuliaML/LearnBase.jl/builds/674968423

If you are ok with it, I can drop support to Julia v1.0 and require Julia >= v1.1 moving forward.
@johnnychen94
Copy link
Member

johnnychen94 commented Apr 14, 2020 •
edited
Loading

I don't think it's a good idea to drop v1.0 support until there's a new LTS Julia version. I believe the test failures can be fixed as commented in #36 (comment)

@juliohm
Copy link
Member Author

juliohm commented Apr 14, 2020

Thank you @johnnychen94 , I've fixed the issue in the test set. Let's see if it passes now.

@juliohm
Copy link
Member Author

juliohm commented Apr 15, 2020

Fixed 👍

@juliohm juliohm closed this as completed Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juliohm @johnnychen94