Skip to content

Commit 1de5b52

Browse files
committedMar 27, 2025·
Rely on isrevertible fallback whenever possible
1 parent 2b3461c commit 1de5b52

12 files changed

+0
-26
lines changed
 

‎src/transforms/closure.jl

-2
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ See also [`Remainder`](@ref).
1313
"""
1414
struct Closure <: StatelessFeatureTransform end
1515

16-
isrevertible(::Type{Closure}) = false
17-
1816
assertions(::Closure) = [scitypeassert(Continuous)]
1917

2018
function applyfeat(::Closure, feat, prep)

‎src/transforms/coalesce.jl

-2
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ Coalesce(cols::C...; value) where {C<:Column} = Coalesce(selector(cols), value)
4444

4545
parameters(transform::Coalesce) = (; value=transform.value)
4646

47-
isrevertible(::Type{<:Coalesce}) = false
48-
4947
colcache(::Coalesce, x) = nothing
5048

5149
colapply(transform::Coalesce, x, c) = coalesce.(x, transform.value)

‎src/transforms/dropextrema.jl

-2
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,6 @@ DropExtrema(cols::C...; low=0.25, high=0.75) where {C<:Column} = DropExtrema(sel
5252

5353
parameters(transform::DropExtrema) = (low=transform.low, high=transform.high)
5454

55-
isrevertible(::Type{<:DropExtrema}) = false
56-
5755
function preprocess(transform::DropExtrema, feat)
5856
cols = Tables.columns(feat)
5957
names = Tables.columnnames(cols)

‎src/transforms/dropmissing.jl

-2
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ DropMissing() = DropMissing(AllSelector())
4141
DropMissing(cols) = DropMissing(selector(cols))
4242
DropMissing(cols::C...) where {C<:Column} = DropMissing(selector(cols))
4343

44-
isrevertible(::Type{<:DropMissing}) = false
45-
4644
function preprocess(transform::DropMissing, feat)
4745
cols = Tables.columns(feat)
4846
names = Tables.columnnames(cols)

‎src/transforms/dropnan.jl

-2
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ DropNaN() = DropNaN(AllSelector())
3535
DropNaN(cols) = DropNaN(selector(cols))
3636
DropNaN(cols::C...) where {C<:Column} = DropNaN(selector(cols))
3737

38-
isrevertible(::Type{<:DropNaN}) = false
39-
4038
_isnan(_) = false
4139
_isnan(x::Number) = isnan(x)
4240

‎src/transforms/filter.jl

-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ struct Filter{F} <: StatelessFeatureTransform
2727
pred::F
2828
end
2929

30-
isrevertible(::Type{<:Filter}) = false
31-
3230
function preprocess(transform::Filter, feat)
3331
# lazy row iterator
3432
rows = tablerows(feat)

‎src/transforms/map.jl

-2
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,6 @@ function Map(pairs::MapPair...)
6262
Map(selectors, funs, targets)
6363
end
6464

65-
isrevertible(::Type{Map}) = false
66-
6765
_funname(fun::Base.Fix1) = "fix1_" * _funname(fun.f)
6866
_funname(fun::Base.Fix2) = "fix2_" * _funname(fun.f)
6967
_funname(fun::ComposedFunction) = _funname(fun.outer) * "_" * _funname(fun.inner)

‎src/transforms/replace.jl

-2
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,6 @@ function Replace(pairs::Pair...)
5858
Replace(selectors, preds, news)
5959
end
6060

61-
isrevertible(::Type{<:Replace}) = false
62-
6361
function applyfeat(transform::Replace, feat, prep)
6462
cols = Tables.columns(feat)
6563
names = Tables.columnnames(cols)

‎src/transforms/sample.jl

-2
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ Sample(size::Int, weights::AbstractWeights; replace=false, ordered=false, rng=Ra
4040

4141
Sample(size::Int, weights; kwargs...) = Sample(size, Weights(collect(weights)); kwargs...)
4242

43-
isrevertible(::Type{<:Sample}) = false
44-
4543
function preprocess(transform::Sample, feat)
4644
# retrieve valid indices
4745
inds = 1:_nrows(feat)

‎src/transforms/satisfies.jl

-2
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ struct Satisfies{F} <: StatelessFeatureTransform
1919
pred::F
2020
end
2121

22-
isrevertible(::Type{<:Satisfies}) = false
23-
2422
function applyfeat(transform::Satisfies, feat, prep)
2523
pred = transform.pred
2624
cols = Tables.columns(feat)

‎src/transforms/select.jl

-4
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ Select(pairs::Pair{C,S}...) where {C<:Column,S<:AbstractString} =
4545

4646
Select() = throw(ArgumentError("cannot create Select transform without arguments"))
4747

48-
isrevertible(::Type{<:Select}) = false
49-
5048
# utils
5149
_newnames(::Nothing, select) = select
5250
_newnames(names::Vector{Symbol}, select) = names
@@ -91,8 +89,6 @@ Reject(cols::C...) where {C<:Column} = Reject(selector(cols))
9189
Reject() = throw(ArgumentError("cannot create Reject transform without arguments"))
9290
Reject(::AllSelector) = throw(ArgumentError("cannot reject all columns"))
9391

94-
isrevertible(::Type{<:Reject}) = false
95-
9692
function applyfeat(transform::Reject, feat, prep)
9793
cols = Tables.columns(feat)
9894
names = Tables.columnnames(cols)

‎src/transforms/sort.jl

-2
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ Sort(cols::C...; kwargs...) where {C<:Column} = Sort(selector(cols), values(kwar
3434

3535
Sort(; kwargs...) = throw(ArgumentError("cannot create Sort transform without arguments"))
3636

37-
isrevertible(::Type{<:Sort}) = false
38-
3937
function preprocess(transform::Sort, feat)
4038
cols = Tables.columns(feat)
4139
names = Tables.columnnames(cols)

0 commit comments

Comments
 (0)
Please sign in to comment.