Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Interpolations ≥ 0.14.3 #46

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

wg030
Copy link
Contributor

@wg030 wg030 commented Sep 26, 2022

Since version 0.14.2 the Interpolations package changed some of its notation from CamelCase to snake_case in accordance to Julia's recommendations.
I simply adjusted the package so that it is now compatible with the latest notation of Interpolations.

@wg030
Copy link
Contributor Author

wg030 commented Sep 26, 2022

Since the last PR #45 hast not been merged yet either, here is a small hint for those of you who are not familiar with Julia's package manager:
By pressing just a ] in the REPL you can switch to the package manager and type in the command
add https://github.com/wg030/NumericalIntegration.jl#pr46
in order to add the version of NumericalIntegration of this pull request to your project.

@wg030
Copy link
Contributor Author

wg030 commented Oct 27, 2022

Closes #47

@bclyons12
Copy link

Any update on this?

@wg030
Copy link
Contributor Author

wg030 commented Jun 6, 2024

Any update on this?

Unfortuantely not and chances are high that this will never be merged since @dextorious, the owner of this repo, has not been active on github for more than two years now.

@dextorious
Copy link
Collaborator

Thank you for explicitly pinging me, those notifications still reach me. I haven't been actively using Julia for a long time and this was always meant to be a feature complete / finished package when I wrote it. Didn't really expect Interpolations.jl to break backwards compatibility when I added that dependency.

Anyway, I'm merging this and I'll try to find a bit of time over the weekend to look at what else might need attention from the issue tracker. Feel free to ping me if you'd like me to look at anything in particular.

@dextorious dextorious merged commit 3d4cc19 into JuliaMath:master Jun 6, 2024
@wg030
Copy link
Contributor Author

wg030 commented Jun 6, 2024

Thank you for explicitly pinging me, those notifications still reach me. I haven't been actively using Julia for a long time and this was always meant to be a feature complete / finished package when I wrote it. Didn't really expect Interpolations.jl to break backwards compatibility when I added that dependency.

Anyway, I'm merging this and I'll try to find a bit of time over the weekend to look at what else might need attention from the issue tracker. Feel free to ping me if you'd like me to look at anything in particular.

@dextorious Great, thanks for merging!

@Eben60
Copy link

Eben60 commented Sep 15, 2024

@dextorious , the registered version of your package according to Julia hub is still v0.3.3. Is there any specific reason for it?

On a side note - if you are not using Julia anymore, could you probably consider transferring the package to some Julia organization?

@SebastianM-C
Copy link
Contributor

It looks like there was no registration after this PR was merged.
We can see that v0.3.3 is the latest version in the registry: https://github.com/JuliaRegistries/General/blob/72f30c3b36e61fb808c0ac670f436dbcdc179308/N/NumericalIntegration/Versions.toml#L10 and there's no PR for a newer version: https://github.com/JuliaRegistries/General/pulls?q=is%3Apr+NumericalIntegration

@dextorious You can register the latest version of the package by commenting with in an issue or on the commit like in 540b6c4#commitcomment-49334987

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Error while trying to register: Register Failed
@SebastianM-C, it looks like you don't have collaborator status on this repository.

@DilumAluthge
Copy link

I think it would be useful to move this package to an organization.

@dextorious If you want, you can transfer this package to my GitHub username, and then I can move it to a relevant GitHub org (maybe JuliaMath). You'll keep your admin privileges on this repo.

@t-bltg
Copy link

t-bltg commented Nov 12, 2024

@dextorious, can we move forward on this topic (organization transfer, release a new version) ?

This is currently blocking package updates ...

@dextorious
Copy link
Collaborator

@dextorious, can we move forward on this topic (organization transfer, release a new version) ?

This is currently blocking package updates ...

Thank you for the ping, sorry I missed the last one. I will transfer the repository to @DilumAluthge, who will then hopefully handle the organization transfer and subsequent releases.

@dextorious
Copy link
Collaborator

I've initiated the transfer, it should automatically complete once @DilumAluthge accepts. Please ping me if anything goes wrong or if I need to undertake any further actions to resolve this.

@t-bltg
Copy link

t-bltg commented Nov 12, 2024

Many thanks 🙏 !

@DilumAluthge
Copy link

Hi @dextorious - sorry, I missed the email about the repo transfer, and now it has expired. Can you initiate the repo transfer to me again?

@dextorious
Copy link
Collaborator

Hi @dextorious - sorry, I missed the email about the repo transfer, and now it has expired. Can you initiate the repo transfer to me again?

@DilumAluthge - sure, should be done now.

@DilumAluthge
Copy link

Thank you @dextorious

@DilumAluthge
Copy link

I'm going to move this repo to https://github.com/JuliaMath for now. If we decide on a better org in the future, we can move it again.

@DilumAluthge
Copy link

Alright, I've transferred this repo to JuliaMath.

@DilumAluthge
Copy link

We'll also need to update the General registry with the new URL: JuliaRegistries/General#119649

@Eben60 Eben60 mentioned this pull request Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants