Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether use_precise_ρ still works #693

Open
schillic opened this issue Oct 4, 2019 · 3 comments
Open

Check whether use_precise_ρ still works #693

schillic opened this issue Oct 4, 2019 · 3 comments
Labels

Comments

@schillic
Copy link
Member

schillic commented Oct 4, 2019

No description provided.

@kpotomkin
Copy link
Collaborator

@schillic @mforets It doesn't work and ρ_helper always takes default implementation of the use_precise_ρ. Any suggestions on why it happens?

@schillic
Copy link
Member Author

schillic commented Dec 6, 2019

It would be helpful to have an example (model, branches, etc.) for debugging.

@schillic
Copy link
Member Author

This is the default implementation:

# default: always apply line search
function use_precise_ρ(𝒫::DiscretePost,
cap::Intersection{N})::Bool where N<:Real
return true
end

We override this policy for LazyDiscretePost:

# usually do not use line search
function use_precise_ρ(𝒫::LazyDiscretePost,
cap::Intersection{N})::Bool where N<:Real
return false
end
# use line search for the outermost level, which is a LinearMap
function use_precise_ρ(𝒫::LazyDiscretePost,
cap::Intersection{N, <:LinearMap{N}}
)::Bool where N<:Real
return true
end

So the question is whether you use LazyDiscretePost or a different operator. What is your expected result?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants