Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need to start opening PRs to add/update compat entries for stdlibs #456

Closed
DilumAluthge opened this issue Oct 14, 2023 · 3 comments · Fixed by #457
Closed

We need to start opening PRs to add/update compat entries for stdlibs #456

DilumAluthge opened this issue Oct 14, 2023 · 3 comments · Fixed by #457

Comments

@vchuravy
Copy link
Member

We can do this automatically with https://github.com/KristofferC/StdlibRegistryCompatUpdater I can either do a PR per stdlib or one large one.

@DilumAluthge
Copy link
Member Author

DilumAluthge commented Oct 14, 2023

There are two separate tasks here:

  1. In the future, CompatHelper.jl needs to open PRs (to Julia package repos) to add or update [compat] entries for stdlibs. (Currently, CompatHelper.jl excludes stdlibs.)
  2. We need to make PRs to the registry to go back and retroactively add [compat] entries for stdlibs.

The first task will be done in #457.

For the second task, @vchuravy it would be great if you can do this (with https://github.com/KristofferC/StdlibRegistryCompatUpdater, presumably). I think it might be easier to do a single large PR, but I would also be fine with a PR per stdlib. @KristofferC do you have a preference (single large PR versus one PR per stdlib)?

@lgoettgens
Copy link
Contributor

This won't work (at least easily) for some stdlibs. SHA.jl changed from julia 1.7 to 1.8 from being version 1.7 to 0.7.

More critical: Test.jl does not have any version number on julia 1.3 and earlier that can be used in a compat entry.

See https://julialang.slack.com/archives/C67910KEH/p1697546952011759

@bors bors bot closed this as completed in 137fa4a Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants