Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rlenv dep for tests #989

Merged
merged 1 commit into from
Oct 12, 2023
Merged

remove rlenv dep for tests #989

merged 1 commit into from
Oct 12, 2023

Conversation

HenriDeh
Copy link
Member

This dependency was making the local testing of RLCore tedious due to compatibility problems. I copied the three environments used in the tests and removed the dependency.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #989 (698fd4b) into main (dd19ee0) will decrease coverage by 1.84%.
The diff coverage is 81.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
- Coverage   13.58%   11.75%   -1.84%     
==========================================
  Files         222      219       -3     
  Lines        7609     7691      +82     
==========================================
- Hits         1034      904     -130     
- Misses       6575     6787     +212     
Files Coverage Δ
...c/ReinforcementLearningCore/test/policies/agent.jl 94.73% <ø> (ø)
...forcementLearningCore/test/policies/multi_agent.jl 100.00% <ø> (ø)
...earningCore/test/environments/rockpaperscissors.jl 71.42% <71.42%> (ø)
...mentLearningCore/test/environments/randomwalk1D.jl 66.66% <66.66%> (ø)
...rcementLearningCore/test/environments/tictactoe.jl 89.01% <89.01%> (ø)

... and 62 files with indirect coverage changes

@jeremiahpslewis jeremiahpslewis enabled auto-merge (squash) October 12, 2023 10:07
@jeremiahpslewis jeremiahpslewis merged commit 3b21982 into main Oct 12, 2023
10 of 14 checks passed
@jeremiahpslewis jeremiahpslewis deleted the rlcore-rlenv branch October 12, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants