@lencheck macro - #216
Closed
arnavk23 wants to merge 9 commits into
Closed
Conversation
Contributor
Author
|
@tmigot please review this pr. |
tmigot
requested changes
Nov 5, 2025
tmigot
left a comment
Member
There was a problem hiding this comment.
This macro is already defined in NLPModels.jl. The issue is more about using it in the package.
tmigot
requested changes
Nov 6, 2025
Contributor
Author
|
Seeing Precompiling packages finished.
1 dependency successfully precompiled in 5 seconds. 54 already precompiled.
Testing Running tests...
Testing MathOptNLPModel
Problem nvar ncon |f(x₀)| ‖∇f(x₀)‖ ‖c(x₀)‖
brownden 4 0 7.9267e+06 2.1405e+06 NA
hs5 2 0 1.0000e+00 3.5355e+00 NA
hs6 2 1 4.8400e+00 4.4000e+00 4.4000e+00
hs10 2 1 2.0000e+01 1.4142e+00 6.0000e+02
hs11 2 1 2.4980e+01 2.8284e-01 2.3910e+01
hs13 2 1 2.0000e+01 8.9443e+00 2.9000e+01
hs14 2 2 1.0000e+00 2.0000e+00 5.3852e+00
lincon 15 11 1.2000e+02 0.0000e+00 0.0000e+00
linsv 2 2 0.0000e+00 1.0000e+00 0.0000e+00
nohesspb 2 0 3.0000e+00 0.0000e+00 NA
hs61 3 2 0.0000e+00 4.3829e+01 0.0000e+00
hs100 7 4 7.1400e+02 1.1024e+02 3.3151e+01
hs219 4 2 1.0000e+01 1.0000e+00 1.0900e+03
quadcon 3 6 0.0000e+00 0.0000e+00 0.0000e+00
operatorspb 6 4 4.2090e+04 3.1000e+01 1.4321e+03
nf 2 2 0.0000e+00 0.0000e+00 0.0000e+00
Testing MathOptNLSModel
Problem nequ nvar ncon ‖F(x₀)‖² ‖JᵀF‖ ‖c(x₀)‖
lls 3 2 1 8.0000e+00 4.4721e+00 0.0000e+00
mgh01 2 2 0 2.4200e+01 1.1643e+02 NA
bndrosenbrock 2 2 0 2.4200e+01 1.1643e+02 NA
nlshs20 2 2 3 9.0900e+02 1.2398e+03 7.1414e+00
nlslc 15 15 11 1.7831e+05 0.0000e+00 0.0000e+00
nlsnohesspb 5 5 0 4.8422e+03 1.1010e+04 NA
hs30 3 3 1 3.0000e+00 1.7321e+00 1.0000e+00
hs43 4 4 3 7.9875e+01 1.1619e+01 1.3748e+01
mgh07 3 3 0 2.5000e+03 9.3982e+02 NA
nlsqc 3 3 6 9.8000e+01 0.0000e+00 0.0000e+00
Testing 2d cat array on NLS
Testing Dense JuMP container on NLS
Testing Sparse JuMP container on NLS
Testing array of JuMP containers on NLS |
tmigot
requested changes
Nov 6, 2025
| @@ -1,5 +1,7 @@ | |||
| module NLPModelsJuMP | |||
|
|
|||
| import NLPModels: @lencheck | |||
Member
There was a problem hiding this comment.
So it's just the import now ? But no use of the macro in the model?
Contributor
Author
There was a problem hiding this comment.
@tmigot I have added changes. If there is anything else you have on mind or any part of the issue I am not understanding, please describe here further.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements @lencheck macro for runtime length checks(fixes #188).