Bump ICU_jll to v74.1 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ICU_jll is not compatible with Julia < 1.6. |
|
This package may need to drop support for Julia < 1.5. |
|
Using Pkg, ICU_jll version can be obtained and this method seems to work. diff --git a/src/StrICU.jl b/src/StrICU.jl
index e89ae6c..8634452 100644
--- a/src/StrICU.jl
+++ b/src/StrICU.jl
@@ -12,8 +12,15 @@ using ModuleInterfaceTools
using ICU_jll
-# for now, just leave this hardcoded, until I can see how to get the version from ICU_jll
-const suffix = "_74"
+using Pkg
+function get_icu_suffix()
+ for (_, v) in Pkg.dependencies()
+ if v.name == "ICU_jll"
+ return v.version.major
+ end
+ end
+end
+const suffix = "_$(get_icu_suffix())"
const iculib = ICU_jll.libicuuc
const iculibi18n = ICU_jll.libicui18n |
|
Thank you for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.