Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring #276

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Code refactoring #276

merged 5 commits into from
Oct 26, 2023

Conversation

rssdev10
Copy link
Collaborator

Code improvements and decoration

@rssdev10
Copy link
Collaborator Author

rssdev10 commented Oct 24, 2023

Test the decorations to get a final table with all the results.
Unfortunately showtime argument of testset is not available in Julia 1.6

Test Summary:                          | Pass  Total   Time
All tests                              |  248    248  11.6s
  📂 coom.jl                           |   18     18   1.3s
    COOM (Co-occurence Matrix)         |   18     18   0.8s
  📂 tokenizer.jl                      |    1      1   0.0s
    Tokenizer                          |    1      1   0.0s
  📂 ngramizer.jl                      |    3      3   0.0s
    NGramizer                          |    3      3   0.0s
  📂 document.jl                       |   32     32   0.4s
    Document                           |   32     32   0.1s
  📂 metadata.jl                       |   20     20   0.3s
    Metadata                           |   20     20   0.3s
  📂 corpus.jl                         |   10     10   1.3s
    Corpus                             |    5      5   0.1s
    Convert Corpus to DataFrames       |    5      5   0.5s
  📂 preprocessing.jl                  |   26     26   0.6s
    Preprocessing                      |   26     26   0.1s
  📂 dtm.jl                            |   29     29   1.8s
    DTM                                |   29     29   1.7s
  📂 stemmer.jl                        |    5      5   0.1s
    Stemmer                            |    5      5   0.0s
  📂 tf_idf.jl                         |   34     34   2.4s
    TFIDF                              |   34     34   2.3s
  📂 lda.jl                            |    3      3   0.8s
    LDA                                |    3      3   0.8s
  📂 lsa.jl                            |    5      5   0.7s
    lsa                                |    5      5   0.7s
  📂 summarizer.jl                     |    4      4   0.5s
    Summarizer                         |    4      4   0.5s
  📂 bayes.jl                          |    3      3   0.3s
    Bayes                              |    3      3   0.3s
  📂 taggingschemes.jl                 |    6      6   0.1s
    Tagging_Schemes                    |    6      6   0.1s
  📂 evaluation_metrics.jl             |   14     14   0.4s
    Service functions check            |    4      4   0.1s
    Evaluation Metrics                 |    6      6   0.3s
    Compare with google-research/rouge |    4      4   0.0s
  📂 LM.jl                             |   32     32   0.4s
    Vocabulary                         |   12     12   0.0s
    preprocessing                      |    7      7   0.0s
    counter                            |    2      2   0.2s
    language model                     |   11     11   0.1s
  📂 translate_evaluation.jl           |    3      3   0.3s
    Evaluation/BLEU                    |    3      3   0.3s
     Testing TextAnalysis tests passed 

@rssdev10 rssdev10 marked this pull request as draft October 24, 2023 02:53
@rssdev10 rssdev10 force-pushed the fix/code_refactoring branch 4 times, most recently from 1cc64a7 to 41def59 Compare October 24, 2023 03:29
@rssdev10 rssdev10 force-pushed the fix/code_refactoring branch 2 times, most recently from 696ce4e to 8bce08d Compare October 24, 2023 15:07
@rssdev10 rssdev10 marked this pull request as ready for review October 24, 2023 15:18
@rssdev10 rssdev10 merged commit 77f1abb into JuliaText:master Oct 26, 2023
7 checks passed
@rssdev10 rssdev10 deleted the fix/code_refactoring branch October 26, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant