Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw appropriate error for pad_sequence input of length > maxlen #183

Open
Ayushk4 opened this issue Jan 10, 2020 · 3 comments · May be fixed by JuliaText/TextModels.jl#17
Open

Throw appropriate error for pad_sequence input of length > maxlen #183

Ayushk4 opened this issue Jan 10, 2020 · 3 comments · May be fixed by JuliaText/TextModels.jl#17
Labels
good-first-issue help wanted good for beginners

Comments

@Ayushk4
Copy link
Member

Ayushk4 commented Jan 10, 2020

TextAnalysis.jl/src/sentiment.jl

Line 4 in f118772

function pad_sequences(l, maxlen=500)

This function returns nothing in case the input length > maxlen.
It will be better to have a proper error handling and err message display for this.
@Ayushk4
Copy link
Member Author

Ayushk4 commented Jan 10, 2020

Thanks to @fungktt for pointing out the above.

@Ayushk4 Ayushk4 mentioned this issue Jan 16, 2020
Open
@bnriiitb
Copy link

@Ayushk4 still some work needed on this?

@Ayushk4
Copy link
Member Author

Ayushk4 commented Jul 24, 2020

I am currently waiting for a response from @sean-gauss , since they already sent a PR.

But, a PR is welcome for fixing this.

@rushabh-v rushabh-v linked a pull request Jan 8, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue help wanted good for beginners
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Throw error if string_length > maxlen in pad_sequences rushabh-v/TextModels.jl
2 participants
@bnriiitb @Ayushk4