Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arrow support for other types #377

Open
omus opened this issue May 19, 2022 · 1 comment
Open

Add Arrow support for other types #377

omus opened this issue May 19, 2022 · 1 comment
Assignees

Comments

@omus
Copy link
Member

omus commented May 19, 2022

Having Arrow support for the various types defined by this package would be great

julia> using Arrow, TimeZones

julia> table = (; col=[FixedTimeZone("UTC-5")])
(col = FixedTimeZone[tz"UTC-05:00"],)

julia> t = Arrow.Table(Arrow.tobuffer(table))
Arrow.Table with 1 rows, 1 columns, and schema:
 :col    NamedTuple{(:name, :offset), Tuple{String, NamedTuple{(:std, :dst), Tuple{Dates.Second, Dates.Second}}}}

julia> eltype(t.col) == FixedTimeZone  # Arrow support would make this `true`
false

Definitely should be called out that Arrow.jl itself has support for ZonedDateTime so we can avoid re-defining those rules

@omus omus self-assigned this May 19, 2022
@omus omus changed the title Support Arrow support Add Arrow support May 19, 2022
@omus omus changed the title Add Arrow support Add Arrow support for other types May 20, 2022
@omus
Copy link
Member Author

omus commented Jun 2, 2022

I'll mention that I worked on this and had Arrow support working for FixedTimeZone outside of the TimeZones.jl package. Oddly, adding it to TimeZones.jl results in me extending a different ArrowTypes module which breaks the support. I haven't had time to dig into further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant