-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework tests to only perform a single fetch data from IANA servers #445
Comments
Definitely should use some GHA caching:
– https://github.com/JuliaTime/TimeZones.jl/actions/runs/5946262840/job/16126554201#step:6:131 Looks like the
– https://github.com/JuliaTime/TimeZones.jl/actions/runs/5946262840/job/16126554082#step:6:137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current TimeZones.jl setup fetches a specific version of the tzdata from the IANA services for running tests. When running on CI this data is always fetched at least once. It was noticed in #441 that we perform a second fetch from the IANA services in
tzdata/build.jl
which hasn't been problematic but causes unnecessary load on their servers.We may also want to look into using GHA caching to avoid downloading from their servers entirely.
The text was updated successfully, but these errors were encountered: