Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpret string datasets as field data #129

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Interpret string datasets as field data #129

merged 3 commits into from
Oct 17, 2023

Conversation

jipolanco
Copy link
Member

Fixes #128

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a002bcb) 96.63% compared to head (f0a118a) 96.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files          15       15           
  Lines         831      832    +1     
=======================================
+ Hits          803      804    +1     
  Misses         28       28           
Files Coverage Δ
src/write_data.jl 96.77% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jipolanco jipolanco merged commit c8b7097 into master Oct 17, 2023
7 of 8 checks passed
@jipolanco jipolanco deleted the write-string branch October 17, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing certain data crashes ParaView
1 participant