Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] HTTP.jl 2.0: Overhaul internals by switching to use aws-crt libraries #1213

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Jan 5, 2025

This isn't quite ready to merge yet, but starting the PR to get CI running and document what there is left to do:

[ ] Incorporate @IanButterworth's recent precompile work
[ ] Update documentation: manual and all inline docs; also write up a 1.X -> 2.0 migration guide
[ ] Update upstream AWS CRT libraries and fix anything required in our wrappers

@quinnj
Copy link
Member Author

quinnj commented Jan 30, 2025

Made some progress here, but blocked on 2 issues I need to dig into:

  • There's an occasional segfault from an unhandled C callback BoundsError; it's when we try to write to the temporary Base.BufferStream and it seems like the code should correctly resize the underlying IOBuffer of the BufferStream, but it doesn't for some reason and then we get a BoundsError; I'm actively investigating this now to try to find out if it's an actual bug in Base.BufferStream/IOBuffer, or how we're using BufferStream (pretty vanilla, but maybe?)
  • There's an sporadic test failure where providing an IOBuffer as a response body seems to sometimes duplicate part of the body writing. Possibly related to the first issue.

@quinnj
Copy link
Member Author

quinnj commented Jan 31, 2025

Ok, turns out the segfault is due to Base.BufferStream readavailable not being threadsafe, there's a PR to fix here: JuliaLang/julia#57211. I'll add a compat shim here until that's fully fixed/released. I can confirm that the same root cause was causing both issues mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant