You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sorry for all the messages. There is an issue with the way you compute the good time chunks for the quality metrics. First it seems you cannot have discontinuous time chunks. But even aside from that there is a bug. If you, e.g., have 4 time chunks and the first one is deemed bad, then currently your code will also drop the last time chunk.
Cheers
Laurenz
The text was updated successfully, but these errors were encountered:
That was a really great catch for the time chunks. Fixed now.
Regarding the discontinuous time chunks, this is on the to-do list but it requires a substantial re-write of certain parts of bombcell. I'm not sure when I will be able to get to it - most likely February next year. Leaving this issue open until then.
Hi Julie,
Sorry for all the messages. There is an issue with the way you compute the good time chunks for the quality metrics. First it seems you cannot have discontinuous time chunks. But even aside from that there is a bug. If you, e.g., have 4 time chunks and the first one is deemed bad, then currently your code will also drop the last time chunk.
Cheers
Laurenz
The text was updated successfully, but these errors were encountered: