Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with computation of timeChunks #46

Open
LaurenzMuessig opened this issue Dec 1, 2023 · 1 comment
Open

issue with computation of timeChunks #46

LaurenzMuessig opened this issue Dec 1, 2023 · 1 comment

Comments

@LaurenzMuessig
Copy link

Hi Julie,

Sorry for all the messages. There is an issue with the way you compute the good time chunks for the quality metrics. First it seems you cannot have discontinuous time chunks. But even aside from that there is a bug. If you, e.g., have 4 time chunks and the first one is deemed bad, then currently your code will also drop the last time chunk.

Cheers

Laurenz

@Julie-Fabre
Copy link
Owner

Hi Laurenz,

No worries, thanks a lot for your message!

That was a really great catch for the time chunks. Fixed now.
Regarding the discontinuous time chunks, this is on the to-do list but it requires a substantial re-write of certain parts of bombcell. I'm not sure when I will be able to get to it - most likely February next year. Leaving this issue open until then.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants