Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Action to use latest node #224

Open
Nithos opened this issue Nov 30, 2022 · 3 comments
Open

Update Action to use latest node #224

Nithos opened this issue Nov 30, 2022 · 3 comments

Comments

@Nithos
Copy link

Nithos commented Nov 30, 2022

GitHub is deprecating Node v12 support in its actions. Can we update this action to use Node 16 or 18.

GitHub Notification

@miguel-fulfil
Copy link

@JulienKode is this github action still maintained? semantic-release is now requiring node 18+, and so being still on 12 seems like a big risk.

@JulienKode
Copy link
Owner

JulienKode commented Feb 9, 2023

Hi @miguel-fulfil @Nithos

Sorry for the delay. Thanks for reporting this issue, this action is still maintained. It's just been a while since I didn't update node version and commitlint version.

I have a PR in progress to use a new node version: #226
But seems there are some issues on it. I'll have to investigate

If you want to help feel free to do some PR's I'll be glad to review them

@chrisjohnson00
Copy link

For those of you wondering how to do this, but don't want to use this action due to the node12 runtime:

The below runs the same as the action.

      - name: Install Dependencies
        # yamllint disable rule:line-length
        run: |
          npm install @commitlint/config-conventional
          echo "module.exports = {extends: ['@commitlint/config-conventional'], rules: { 'subject-case': [0,'always',['sentence-case']],'header-max-length': [2, 'always', 120], 'body-max-line-length': [0, 'always', 120] }};" > commitlint.config.js
        # yamllint enable rule:line-length
      - name: Lint the PR Title
        run: |
          echo "${PR_TITLE}" | npx --yes commitlint
        env:
          PR_TITLE: '${{ github.event.pull_request.title }}'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants