Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve package load time #144

Open
pfitzseb opened this issue Jul 24, 2017 · 8 comments · May be fixed by #277
Open

Improve package load time #144

pfitzseb opened this issue Jul 24, 2017 · 8 comments · May be fixed by #277
Assignees

Comments

@pfitzseb
Copy link
Member

ink is sitting at ~200ms for me, which seems pretty excessive (considering that atom-ide-ui for example only takes ~50ms).

@ahogen
Copy link

ahogen commented Aug 3, 2017

I get even worse! Granted, I have some other large apps open right now so maybe my hard drive was being used at the time. However, literally all the worst times are related to Juno/Julia/Ink... ☹️

capture

@pfitzseb
Copy link
Member Author

pfitzseb commented Aug 3, 2017

Ouch, that looks horrible.

@dpo
Copy link

dpo commented Jul 23, 2018

The load time has become absolutely astounding. The Ink load time is more than double the load time of all the other packages I use that take more than 5ms to load combined, and about 1.5 times more than the load time of all the packages I use combined!

screen shot 2018-07-23 at 11 26 00

@pfitzseb
Copy link
Member Author

Oh wow, that's really bad. Will look into it soon.

@pfitzseb pfitzseb self-assigned this Jul 23, 2018
@pfitzseb
Copy link
Member Author

Lazy loading FTW:
image

I'll release a new version tomorrow. :)

@pfitzseb
Copy link
Member Author

Okay, that was a bit too optimistic -- the best I have now which also doesn't break anything is
image

In the screenshot in the post above I accidentally broke deserialization of the terminal, plot pane etc. pp., which obviously makes things much faster.

@aminya
Copy link

aminya commented Nov 13, 2019

For me, ink was 200 ms for the first boot, but next times around 130 ms.

image

I believe we should disable the linter inside ink and instead contribute to linter-julia to improve the speed a little
https://atom.io/packages/linter-julia
Setting up a language server would be easy, and we can use the same UI that other languages use in Atom, to save some speed instead of creating a separate UI for julia

@aminya
Copy link

aminya commented Nov 24, 2019

Atom-ide-ui package that provides almost the same features have 1/4 of the load time of atom-ink:
image

@aminya aminya linked a pull request May 28, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants