Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomResistorExtraction: show faulty device in GUI #1608

Closed
klayoutmatthias opened this issue Feb 1, 2024 · 1 comment · Fixed by #1615
Closed

CustomResistorExtraction: show faulty device in GUI #1608

klayoutmatthias opened this issue Feb 1, 2024 · 1 comment · Fixed by #1615
Assignees
@klayoutmatthias
Labels
bug
Milestone
0.28.16

Comments

@klayoutmatthias
Copy link
Collaborator

This relates to this problem: https://www.klayout.de/forum/discussion/2462/customresistorextraction-show-faulty-device-in-gui#latest
@klayoutmatthias
Copy link
Collaborator Author

klayoutmatthias commented Feb 1, 2024 •
edited
Loading

Testcase is here:

issue_1608.zip

Quick analysis: for caching purposes, the shape group of the device is normalized, but the transformation is not considered for the error markers. Also, in the presence of warnings or errors, the devices should not be cached.

Code: dbNetlistDeviceExtractor.cc, line 291.

@klayoutmatthias klayoutmatthias self-assigned this Feb 4, 2024
@klayoutmatthias klayoutmatthias added this to the 0.28.16 milestone Feb 4, 2024
@klayoutmatthias klayoutmatthias linked a pull request Feb 4, 2024 that will close this issue
Issue 1609 #1613
Merged
@klayoutmatthias klayoutmatthias removed a link to a pull request Feb 5, 2024
Issue 1609 #1613
Merged
@klayoutmatthias klayoutmatthias linked a pull request Feb 5, 2024 that will close this issue
Issue 1608 #1615
Merged
klayoutmatthias pushed a commit that referenced this issue Feb 5, 2024
Fixed issue #1608 (Device extractor error shape)
f768be6
klayoutmatthias added a commit that referenced this issue Feb 11, 2024
@klayoutmatthias
Issue 1608 (#1615)
f37e373 
* Fixed issue #1608 (Device extractor error shape)

* New test data

* Add-on: pressing Esc on the netlist or marker browser clears markers

* Updated test data

---------

Co-authored-by: Matthias Koefferlein <[email protected]>
klayoutmatthias added a commit that referenced this issue Feb 11, 2024
@klayoutmatthias
Issue 1608 (#1615)
51bad46 
* Fixed issue #1608 (Device extractor error shape)

* New test data

* Add-on: pressing Esc on the netlist or marker browser clears markers

* Updated test data

---------

Co-authored-by: Matthias Koefferlein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klayoutmatthias klayoutmatthias

Labels
bug
Projects
None yet
Milestone
0.28.16
Development

Successfully merging a pull request may close this issue.

Issue 1608 KLayout/klayout
1 participant
@klayoutmatthias