Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build should run psql tests, requires psql service in github actions #400

Open
mgrunbauer opened this issue Sep 2, 2024 · 0 comments

Comments

@mgrunbauer
Copy link
Collaborator

Adaguc supports both PostgreSQL and SQLite as database back-ends, however we want to deprecate SQLite and only support PostgreSQL.

The PR #361 adds the file runtests_psql.sh which can already run the tests against PostgreSQL during the docker build. This works when building adaguc on a local system. Note that this requires a running PostgreSQL server reachable on port 5432.

We should try using a PostgreSQL service in GitHub Actions. This would allow us to run all tests against PostgreSQL. If this works, we can remove support for SQLite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant