Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gimbal breaking on configs #240

Open
Capkirk123 opened this issue May 30, 2020 · 4 comments
Open

Gimbal breaking on configs #240

Capkirk123 opened this issue May 30, 2020 · 4 comments

Comments

@Capkirk123
Copy link
Member

If an engine has gimballing capability, but it has a config without gimbal (set by using gimbalRange = 0 in ModuleEngineConfigs), then selecting that config will permanently break the gimbal on that part, even if other configs are selected. The gimbal will only be restored if the part is replaced.

To reproduce:

  1. Select and engine that has a gimbal on some configs, and none on others (the NK15/33 is a good example, if you have RO)

  2. Observe the engine gimbal functions, either by using RCS build aid or launching the vessel

  3. Select a config with 0 degrees of gimbal, and then select the original config

  4. Observe the gimbal no longer functions, using RCS build aid or by launching the vessel

@Starwaster
Copy link
Contributor

Can you look at the config for that engine and check if the other (non-zero) configs have the gimbalRange field at all?

I have a suspicion as to why this might happen but my PC is down and I’m limited to my iPhone.

But what I think is happening is that some configs are lacking explicit gimbalRange definition. If such a config is loaded it should fallback to the base engine config. It sounds like it is not.

@Starwaster
Copy link
Contributor

Also, Explicitly defining gimbal for all configs should resolve.

@Capkirk123
Copy link
Member Author

Yes, explicitly defining the gimbal range for all configs fixes the problem.

@Starwaster
Copy link
Contributor

Starwaster commented Jun 12, 2020

If you’re in the RO/RP1 discord channel, please tell them I suggest explicit gimbal config for all MEC configs if any MEC touches the gimbal.

My PC is down and I’m waiting on a replacement PSU but supply line disruption means I have no idea when it’ll get here. Otherwise I’d tell them myself

When I’m back up and running I’ll make code changes so it has a fallback. (Thought I had already but maybe not. Don’t feel like code diving on my phone)

lpgagnon added a commit to lpgagnon/RealismOverhaul that referenced this issue Nov 19, 2020
per
KSP-RO/RealFuels#240 (comment)

Explicitly specify a gimbal in every CONFIG, instead of only
overriding the ModuleGimbal value in configs that want something else
DRVeyl pushed a commit to KSP-RO/RealismOverhaul that referenced this issue Nov 21, 2020
per KSP-RO/RealFuels#240 (comment)

Explicitly specify a gimbal in every CONFIG, instead of only overriding the ModuleGimbal value in configs that want something else
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants