Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated textures where one is an unsupported format (e.g. DXT3) will fail to load the supported one #237

Open
JonnyOThan opened this issue Jul 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@JonnyOThan
Copy link
Contributor

JonnyOThan commented Jul 4, 2024

https://forum.kerbalspaceprogram.com/topic/204002-18-112-kspcommunityfixes-bugfixes-and-qol-tweaks/?do=findComment&comment=4404427

Kerbal Aircraft Expansion has a few duplicated textures where one is a png and the other is dxt3. Without KSPCF, the game tries to load the dds first, fails, and then successfully loads the png and things work. With KSPCF, it fails on the dxt3 but then does not load the png (it spits out the "duplicate png texture" log message).

@JonnyOThan JonnyOThan added the bug Something isn't working label Jul 4, 2024
@Lisias
Copy link

Lisias commented Jul 4, 2024

Uh, IMHO, this is not a bug, but an enhancement.

The bug is on KAX. Being able to detect the bug, IMHO, would be an enhancement to KSPCF.

@JonnyOThan
Copy link
Contributor Author

Well, one of the pillars of KSPCF is that it should match stock behaviors (other than bug fixes) as closely as possible. I don’t think there’s much of a downside to making sure that a failed dds load doesn’t prevent the png from being loaded. This is especially important considering that mods that are affected by this likely aren’t getting any additional updates (or else why would they be using dxt3?) and the error messages will be in the logs whether KSPCF is installed or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants