Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A potential bug for determining time steps to be sampled #140

Open
keiyamamo opened this issue Feb 23, 2024 · 0 comments
Open

A potential bug for determining time steps to be sampled #140

keiyamamo opened this issue Feb 23, 2024 · 0 comments

Comments

@keiyamamo
Copy link
Collaborator

Hi @hkjeldsberg

If I understand correctly, save_frequency is the time step frequency used during the simulation, while step is how often you want to save the outputs.

saved_time_steps_per_cycle = int(T / dt / save_frequency / step)

Here, saved_time_steps_per_cycle is divided by both save_frequency and step, but shouldn’t it be only save_frequency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant