Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accountSharableAfterExchange 字样 #263

Open
HikariCalyx opened this issue Jun 25, 2024 · 2 comments
Open

accountSharableAfterExchange 字样 #263

HikariCalyx opened this issue Jun 25, 2024 · 2 comments

Comments

@HikariCalyx
Copy link
Contributor

HikariCalyx commented Jun 25, 2024

CMS V208 更新起出现了一种新的交易状态:accountSharableAfterExchange。此交易状态也存在于其它已更新 Dreamer 改版的客户端(含 KMS)。
该交易状态的游戏截图参考以下网站。
https://mxdact.web.sdo.com/project/v208/02-4.html#con

目前已知存在该属性的道具为 2637169,即以上网站展示的道具。
image

@Kagamia
Copy link
Owner

Kagamia commented Jul 6, 2024

感谢提交。

我在思考原来有一些道具存在accountSharablesharableOnce的属性,wc还没有正确实现,当累积到一起的时候会不会出现逻辑错误。
一个示例道具像是这样:
1114327

这个PR可能需要hold一段时间,我们应该先统计全部具有和“道具转移”相关特殊属性的物品,研究布局规律再做综合设计。

@PirateIzzy
Copy link
Contributor

PirateIzzy commented Oct 23, 2024

Hi Kagamia, just wanted to let you know that this is properly formatted in the GMS and KMS forks.
1114327

It's due to the way the GetItemAttributeString() function in ItemTooltipRender2 is set up. The CMS build returns a regular string object while the GMS/KMS forks returns a List, and changing it may cause issues with the rest of the file.

Here are the GMS and KMS versions of ItemTooltipRender2:
https://github.com/PirateIzzy/WzComparerR2/blob/master/WzComparerR2/CharaSimControl/ItemTooltipRender2.cs
https://github.com/KENNYSOFT/WzComparerR2/blob/kms/WzComparerR2/CharaSimControl/ItemTooltipRender2.cs

Kagamia pushed a commit that referenced this issue Nov 30, 2024
* Update FrmPatcher.cs

* Update FrmPatcher.cs

* fix indent

* fix new line

* Add accountSharableAfterExchange support, #263

* add MSN exclusive props

* Add scroll enhancement color support

* Update GearTooltipRender2.cs

* Revert changes about #e , but keep ScrollEnhancementColor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants