Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Case-insensitive image sorting #310

Open
PirateIzzy opened this issue Feb 15, 2025 · 2 comments
Open

Feature Request: Case-insensitive image sorting #310

PirateIzzy opened this issue Feb 15, 2025 · 2 comments

Comments

@PirateIzzy
Copy link
Contributor

PirateIzzy commented Feb 15, 2025

In the CMS build, IMG sorting is case-sensitive, meaning that it sorts by uppercase, and then by lowercase.
Image

In the KMS build, IMG sorting is case-insensitive due to a feature in Wz_Node:
Image

KENNYSOFT@c9e627a

Could we add this to the CMS build as well? Whether it's exactly like this or if you know a better method is up to you.
Alternatively, we can add an option to choose how to sort IMGs, between these two methods.

@Kagamia
Copy link
Owner

Kagamia commented Feb 15, 2025

StrCmpLogicalW is quite heavy and also causes WzLib to lose cross-platform compatibility. However it is a better choice for human readability,and it can also corectly sort acc1, acc2, acc3 ...acc10, acc11.

We can design an external string comparer or a full managed implementation of lexicographical_compare, we can try to add it as an option.

@PirateIzzy
Copy link
Contributor Author

PirateIzzy commented Feb 17, 2025

Just an addendum, the Sort by IMG option also allows you to turn StrCmpLogicalW sorting on / off:
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants