Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing set effects #72

Open
Sunaries opened this issue May 20, 2018 · 6 comments
Open

Missing set effects #72

Sunaries opened this issue May 20, 2018 · 6 comments

Comments

@Sunaries
Copy link

Sunaries commented May 20, 2018

In-game
t

WCR2
t

I don't know if CMS has this fishing equipment. The ID for the ring is 1113278.

setItemID 626:

  <dir name="626">
    <string name="setItemName" value="Fishing Set" />
    <int16 name="completeCount" value="3" />
    <int16 name="parts" value="1" />
    <dir name="ItemID">
      <dir name="1">
        <int32 name="1" value="1113273" />
        <int32 name="2" value="1113274" />
        <int32 name="3" value="1113275" />
        <int32 name="4" value="1113276" />
        <int32 name="5" value="1113277" />
        <int32 name="6" value="1113278" />
      </dir>
      <dir name="2">
        <int32 name="1" value="1122366" />
        <int32 name="2" value="1122367" />
        <int32 name="3" value="1122368" />
        <int32 name="4" value="1122369" />
        <int32 name="5" value="1122370" />
        <int32 name="6" value="1122371" />
      </dir>
      <dir name="3">
        <int32 name="1" value="1132302" />
        <int32 name="2" value="1132303" />
        <int32 name="3" value="1132304" />
        <int32 name="4" value="1132305" />
        <int32 name="5" value="1132306" />
        <int32 name="6" value="1132307" />
      </dir>
    </dir>
    <dir name="Effect">
      <dir name="2">
        <dir name="bonusByTime">
          <dir name="0">
            <int32 name="incPQExpR" value="3" />
            <int32 name="termStart" value="0" />
          </dir>
          <dir name="1">
            <int32 name="incPQExpR" value="6" />
            <int32 name="termStart" value="1" />
          </dir>
          <dir name="2">
            <int32 name="incPQExpR" value="9" />
            <int32 name="termStart" value="2" />
          </dir>
        </dir>
      </dir>
      <dir name="3">
        <dir name="bonusByTime">
          <dir name="0">
            <int32 name="incExpR" value="3" />
            <int32 name="termStart" value="0" />
          </dir>
          <dir name="1">
            <int32 name="incExpR" value="6" />
            <int32 name="termStart" value="1" />
          </dir>
          <dir name="2">
            <int32 name="incExpR" value="9" />
            <int32 name="termStart" value="2" />
          </dir>
        </dir>
      </dir>
    </dir>
    <int32 name="jokerPossible" value="1" />
  </dir>
@KENNYSOFT
Copy link
Contributor

Oh, new property for set item! Interesting :)

@Kagamia
Copy link
Owner

Kagamia commented May 29, 2018

There is no such a item or setitem in CMST.139 😭
I don't know how to explain it.

@Kagamia
Copy link
Owner

Kagamia commented Jul 4, 2018

Not fully tested. 😭
No such a setItem property could be found from CMST or KMST.

@Sunaries
Copy link
Author

Sunaries commented Jul 4, 2018

@Kagamia

I've incorporated the code. Result:

WCR2
t

EXP line is missing.

@Kagamia
Copy link
Owner

Kagamia commented Jul 4, 2018

How about build a master version of wc?

I'm not sure what cause the bugs.

Or, set a breakpoint on https://github.com/Kagamia/WzComparerR2/blob/master/WzComparerR2/CharaSimControl/SetItemTooltipRender.cs#L304 then check if p.Props has values.

@Sunaries
Copy link
Author

Sunaries commented Jul 7, 2018

Hm, I can't quite get it to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants