Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylesheet updates #9

Open
kaiwalyakoparkar opened this issue Apr 4, 2021 · 0 comments
Open

Stylesheet updates #9

kaiwalyakoparkar opened this issue Apr 4, 2021 · 0 comments
Labels
bug Something isn't working Css Tasks requiring css help wanted Extra attention is needed TYT No urgency in completing the task wontfix This will not be worked on

Comments

@kaiwalyakoparkar
Copy link
Member

  • To curve the edges you need to add overflow: hidden to your .container class.

  • Also, I recommend adding a min-width to your card so that the content doesn't get "pressed".

  • You can add min-height : 100vh to your body to make sure that it covers your viewport.

  • Instead of using padding to put your card in the center, you could just using justify-content : center and align-item: center as your body is already set on display: flex.

  • Define width/height of your components with units such as percentages/rem/rem/etc... then playing with grid/flex/position properties to place your elements.

  • Try to take a look about semantic HTML tags such as main, section, etc.. to make your code more descriptive.

  • Get rid of the default padding/margin with *{margin : 0; padding:0;} also you might take a look at box-sizing : border-box and understand how the box model works under the hood.

@kaiwalyakoparkar kaiwalyakoparkar added bug Something isn't working Css Tasks requiring css help wanted Extra attention is needed TYT No urgency in completing the task wontfix This will not be worked on labels Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Css Tasks requiring css help wanted Extra attention is needed TYT No urgency in completing the task wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant