fix: improve error handling - #3321
Open
saurabhhhcodes wants to merge 1 commit into
Open
Conversation
📝 WalkthroughWalkthroughThe PR bounds numeric RSS entity parsing and specifies radix 10 when converting widget gallery tab keys. ChangesParsing updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@examples/rss-reader/src/index.tsx`:
- Around line 30-35: Update both numeric-entity branches in the entity-decoding
logic to validate the complete payload before conversion: stop parsing a fixed
ten-character prefix, reject entities with oversized significant digits or
trailing invalid characters, and only call String.fromCodePoint when the
resulting codePoint is finite and within 0 through 0x10FFFF; otherwise return
match.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 38a7ddf9-3735-49e9-83f4-357ae92cf19f
📒 Files selected for processing (2)
examples/rss-reader/src/index.tsxexamples/widget-gallery/src/index.ts
Comment on lines
+30
to
+35
| const codePoint = Number.parseInt(entity.slice(2, 10), 16); | ||
| return Number.isFinite(codePoint) ? String.fromCodePoint(codePoint) : match; | ||
| } | ||
|
|
||
| if (entity.startsWith('#')) { | ||
| const codePoint = Number.parseInt(entity.slice(1), 10); | ||
| const codePoint = Number.parseInt(entity.slice(1, 10), 10); |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Validate the complete numeric entity before conversion.
slice(..., 10) parses only a prefix, so an oversized entity such as � can be silently decoded from truncated data instead of falling back to match. Number.isFinite also allows values above 0x10FFFF, which can make String.fromCodePoint throw on RSS input. Reject oversized significant payloads and require 0 <= codePoint <= 0x10FFFF in both branches.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@examples/rss-reader/src/index.tsx` around lines 30 - 35, Update both
numeric-entity branches in the entity-decoding logic to validate the complete
payload before conversion: stop parsing a fixed ten-character prefix, reject
entities with oversized significant digits or trailing invalid characters, and
only call String.fromCodePoint when the resulting codePoint is finite and within
0 through 0x10FFFF; otherwise return match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit