Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPUB: The rendered image is darker than the original image even on white theme. #3449

Open
mozophe opened this issue Dec 10, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@mozophe
Copy link

mozophe commented Dec 10, 2024

What happened?

The image rendered by the EPUB book reader is darker than the original image, even on the white theme. This makes it more difficult to read images. I did not see an option to adjust this brightness.

I suspect the issue is arising from

filter: brightness(0.85) !important;

Is there a way to change this behaviour on a deployed version?

Edit: This should be applicable for all non-dark themes, namely white and paper at the moment.
Only need to change the brightness from 0.85 to 1 for non-dark themes and the bug should be fixed.

What did you expect?

The image is rendered as original or an option to adjust the brightness.

Kavita Version Number - If you don not see your version number listed, please update Kavita and see if your issue still persists.

0.8.4.2 - Stable

What operating system is Kavita being hosted from?

Linux

If the issue is being seen on Desktop, what OS are you running where you see the issue?

Linux

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Chrome

If the issue is being seen on Mobile, what OS are you running where you see the issue?

None

If the issue is being seen on the Mobile UI, what browsers are you seeing the problem on?

No response

Relevant log output

No response

Additional Notes

Running Kavita on a Raspberry Pi using Linux native install

@mozophe mozophe added the needs-triage Needs to be triaged by a developer and assigned a release label Dec 10, 2024
@majora2007
Copy link
Member

This is on purpose as the non-darkened image against the dark background is uncomfortable. I would ask to create a FR request instead to make it derived from a setting rather than hardcoded.

@majora2007
Copy link
Member

Okay this was my bad. I must have misread the issue. You're right, the image shouldn't be darkened on the white theme.

@majora2007 majora2007 added bug Something isn't working and removed needs-triage Needs to be triaged by a developer and assigned a release labels Dec 11, 2024
@majora2007 majora2007 moved this from To Do to In Progress in v0.8.5 - Kavita+ UX Overhaul Dec 13, 2024
@majora2007 majora2007 moved this from In Progress to Done in v0.8.5 - Kavita+ UX Overhaul Dec 13, 2024
@majora2007 majora2007 moved this from Done to Done, Not Pushed in v0.8.5 - Kavita+ UX Overhaul Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done, Not Pushed
Development

No branches or pull requests

2 participants