Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Sample Layout with icons only #15

Open
MathiasDL opened this issue Oct 21, 2024 · 5 comments
Open

Provide Sample Layout with icons only #15

MathiasDL opened this issue Oct 21, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@MathiasDL
Copy link

For Android and iOS, the default camera view uses icons for Capture, Flash, Back/front view.

The current sample uses Text Buttons instead. I would advise to also add a view with icons only, which you can even incorporate into the library itself as a default view. I would think most developers would go with such a default view, reducing the amount of code needed to implement this library. This has as an added bonus that you do not need to deal with localization, and you can also add a screenshot to the Readme.

@Kashif-E
Copy link
Owner

@MathiasDL can you share a sample? so I can understand this better an image would work

@MathiasDL
Copy link
Author

See the link I posted, or a screenshot of the default camera view on my Samsung phone, relevant icons circled. As you can see, no text is required:

Screenshot_20241024_161010_Camera

@Kashif-E
Copy link
Owner

got ya, ill try to this asap

@Kashif-E Kashif-E self-assigned this Oct 24, 2024
@Kashif-E Kashif-E added the enhancement New feature or request label Oct 24, 2024
@MathiasDL
Copy link
Author

That would be great, I did some more research into other KMP camera apps but did not find any satisfying one, so CameraK definitely has its place!

@Kashif-E
Copy link
Owner

thanks @MathiasDL, I really appreciate that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants