Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure with PHP 7.2.0-dev #108

Closed
remicollet opened this issue May 15, 2017 · 3 comments
Closed

Test failure with PHP 7.2.0-dev #108

remicollet opened this issue May 15, 2017 · 3 comments
Labels

Comments

@remicollet
Copy link
Contributor

+ php72 /usr/bin/nette-tester --colors 0 -p php72 -C tests/KdybyTests -s
 _____ ___  ___ _____ ___  ___
|_   _/ __)( __/_   _/ __)| _ )
  |_| \___ /___) |_| \___ |_|_\  v2.0.x

PHP 7.2.0-dev (cli) | php72 | 8 threads

.........................................F.....F............

-- FAILED: Kdyby\Events\Extension. | KdybyTests/Events/Extension.phpt [method=testAutowire]
   Exited with error code 255 (expected 0)
   E_DEPRECATED: The each() function is deprecated. This message will be suppressed on further calls
   
   in Nette/Http/RequestFactory.php(114) 
   in Tester/Framework/TestCase.php(124) call_user_func_array()
   in [internal function]Tester\TestCase->Tester\{closure}()
   in Nette/Http/RequestFactory.php(114) each()
   in cache/Nette.Configurator/Container_315f70ef90.php(183) Nette\Http\RequestFactory->createHttpRequest()
   in Nette/DI/Container.php(179) Container_315f70ef90->createServiceHttp__request()
   in Nette/DI/Container.php(105) Nette\DI\Container->createService()
   in cache/Nette.Configurator/Container_315f70ef90.php(103) Nette\DI\Container->getService()
   in Nette/DI/Container.php(179) Container_315f70ef90->createServiceApplication__application()
   in Nette/DI/Container.php(105) Nette\DI\Container->createService()
   in Nette/DI/Container.php(103) Nette\DI\Container->getService()
   in KdybyTests/Events/Extension.phpt(139) Nette\DI\Container->getService()
   in [internal function]KdybyTests\Events\ExtensionTest->testAutowire()
   in Tester/Framework/TestCase.php(143) call_user_func_array()
   in Tester/Framework/TestCase.php(50) Tester\TestCase->runTest()
   in tests/KdybyTests/bootstrap.php(36) Tester\TestCase->run()
   in KdybyTests/Events/Extension.phpt(358) run()

-- FAILED: Kdyby\Events\Extension. | KdybyTests/Events/Extension.phpt [method=testAutowireAlias]
   Exited with error code 255 (expected 0)
   E_DEPRECATED: The each() function is deprecated. This message will be suppressed on further calls
   
   in Nette/Http/RequestFactory.php(114) 
   in Tester/Framework/TestCase.php(124) call_user_func_array()
   in [internal function]Tester\TestCase->Tester\{closure}()
   in Nette/Http/RequestFactory.php(114) each()
   in cache/Nette.Configurator/Container_f70c8df11b.php(186) Nette\Http\RequestFactory->createHttpRequest()
   in Nette/DI/Container.php(179) Container_f70c8df11b->createServiceHttp__request()
   in Nette/DI/Container.php(105) Nette\DI\Container->createService()
   in cache/Nette.Configurator/Container_f70c8df11b.php(106) Nette\DI\Container->getService()
   in Nette/DI/Container.php(179) Container_f70c8df11b->createServiceApplication__application()
   in Nette/DI/Container.php(105) Nette\DI\Container->createService()
   in cache/Nette.Configurator/Container_f70c8df11b.php(98) Nette\DI\Container->getService()
   in Nette/DI/Container.php(179) Container_f70c8df11b->createServiceAlias()
   in Nette/DI/Container.php(105) Nette\DI\Container->createService()
   in KdybyTests/Events/Extension.phpt(307) Nette\DI\Container->getService()
   in [internal function]KdybyTests\Events\ExtensionTest->testAutowireAlias()
   in Tester/Framework/TestCase.php(143) call_user_func_array()
   in Tester/Framework/TestCase.php(50) Tester\TestCase->runTest()
   in tests/KdybyTests/bootstrap.php(36) Tester\TestCase->run()
   in KdybyTests/Events/Extension.phpt(358) run()


FAILURES! (60 tests, 2 failures, 2.1 seconds)

Yes, really early report ;)

@fprochazka
Copy link
Member

fprochazka commented May 15, 2017

Thank you :) Guess I should add the nightly to the Travis build. Also, what version is this?

Btw you see that it's a Nette bug, right? :)

@fprochazka fprochazka added the bug label May 15, 2017
@remicollet
Copy link
Contributor Author

Also noticed in Fedora QA (using 7.2.0RC6)
https://apps.fedoraproject.org/koschei/package/php-kdyby-events?collection=f28

I noticed #112 but code have change a lot from 3.1.0
So I adapt this for 3.1.0
https://src.fedoraproject.org/cgit/rpms/php-kdyby-events.git/plain/php-kdyby-events-php72.patch

Test suite passes with 5.6, 7.0, 7.1 and 7.2 (using all stable Nette components of nette 2.4)

@enumag
Copy link
Member

enumag commented Dec 3, 2017

@remicollet Can this be closed now? #112 is merged.

@enumag enumag closed this as completed Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants