You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
be without the exclamation mark? Because after update to Kdyby/Events 3.1.1 on our projects (we have custom Presenters, Application etc.) it stopped handle events from these over-written classes. So not I am trying to figure out, whether the behaviour before this update was working just as side-effect/bug or now there is a bug :-)
Thanks!
The text was updated successfully, but these errors were encountered:
Indeed this is a bug. It was done by accident during coding style refactoring in this commit. It should be if (!$class) { or if (empty($class)) (. The first might be better because that's what was used before the buggy commit. Send PR please!
Maybe I just don't understand the meaning of the code, but shouldn't the condition in here:
Events/src/Events/DI/EventsExtension.php
Line 386 in ca3e8d2
be without the exclamation mark? Because after update to Kdyby/Events 3.1.1 on our projects (we have custom Presenters, Application etc.) it stopped handle events from these over-written classes. So not I am trying to figure out, whether the behaviour before this update was working just as side-effect/bug or now there is a bug :-)
Thanks!
The text was updated successfully, but these errors were encountered: