Event namespaces respect class inheritance #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fprochazka
changed the title
|
Any thoughts @janlanger, @PavelJurasek, @norbe ? |
|
👍 |
|
👍 Well, my thought in #25 was same behavior, I guess I should describe it better back then :-) |
|
It solves my needs (i'm also using it for repositories events) in more optimized way than at my solution... |
|
|
|
|
|
|
|
I might, but I'm not sure when :) |
|
Maybe we can use tests from #44? |
|
We probably can! |
Added tests for event namespaces
|
@fprochazka Merge? |
|
I haven't notice the tests beeing added, github is not creating any notification for push into branch. I will try to look into this ASAP :) |
|
Wow, it really happened :) Thank you guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without tests for now
[closes #55]