Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: How many versions of R do we want to support? #241

Open
Hugovdberg opened this issue Apr 29, 2018 · 5 comments
Open

Discussion: How many versions of R do we want to support? #241

Hugovdberg opened this issue Apr 29, 2018 · 5 comments
Labels
Milestone

Comments

@Hugovdberg
Copy link
Collaborator

Currently we have custom functions because certain functionality was only introduced in "newer" versions of R. For example the .list.files.and.directories function that strips the . and .. entries because the argument no.. was not available in R 2.15.3 (the last version of the R 2.x series). R 3.0.0 was released in april 2013. Do we actually support versions this old and do we still want to support those versions? Do we check if the current functionality isn't actually broken because of dependencies that don't support such old versions of R?

@rsangole
Copy link
Collaborator

Good Q. I'd imagine there would be very few - if any - users still using the legacy 2.x code. The R community I have seen is quite quick to pick up and adopt the new releases, and then again, 3.x has been available since 2013.

If I had to make a call, I would not support R at 2.x.

@Hugovdberg
Copy link
Collaborator Author

Just an extra argument, this function .list.files.and.dirs was created specifically for two calls to list.files in 2014, I think we've waited long enough for R 2.x to be replaced with R 3.x.

@KentonWhite
Copy link
Owner

I also agree to stop supporting R at 2.x. Lets add in notifications on the Github version that support for 2.x will be deprecated in a newer version. I will do a minor point release when the feather caching is complete (assuming the feather caching doesn't break backward compatibility) and then plan a major point release in summer where 2.x is no longer supported.

@Hugovdberg
Copy link
Collaborator Author

https://community.rstudio.com/t/determining-which-version-of-r-to-depend-on/4396:

The Tidyverse has a nominal goal to support R >= 3.1, which we are actively working to make true. IME the backports package is very useful and its README is the most succinct summary around of exactly which functions are going to cause you trouble:

If we actually plan to convert to the tidyverse natively then we should follow the same goal of supporting R >= 3.1.

@KentonWhite
Copy link
Owner

Ok lets support R>= 3.1 as suggested.

@rsangole rsangole added this to the 1.0 milestone May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants