Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Move data import of csv data to "readr" functions (part of "tidyverse") #255

Open
shainen opened this issue May 2, 2018 · 2 comments
Milestone

Comments

@shainen
Copy link

shainen commented May 2, 2018

Right now, ProjectTemplate automatically imports csv files with read.csv (the default function for this kind of thing from the "utils" package). It does irritating things like convert spaces in column names to periods.

Included in the "tidyverse" is the "readr" package, which has nicer functions to import rectangular data. For csv, there is read_csv. Since there is already momentum to make ProjectTemplate inline the tidyverse, this seems worth doing.

I believe it is mostly accomplished by changing "read.csv" to "read_csv" in csv.reader.R, but there may be more to it.

Possible problem would be backwards compatibility for projects already started; using the new library would mean the names of data_frame's would be different (e.g. now spaces in original column names in csv would now be preserved).

@KentonWhite KentonWhite added Feature Under investigation Default label before an issue is classified as Bug/Feature/... and removed Feature labels May 2, 2018
@rsangole
Copy link
Collaborator

rsangole commented May 2, 2018

@KentonWhite and @Hugovdberg , this has been on my mind for a while too, and I believe it'll be part of #230 at the very least. read_csv is certainly a lot better than read.csv: it's faster (5x-10x), handles columns better, and returns a tibble, among other things.

@Hugovdberg
Copy link
Collaborator

I agree we should move to the tidyverse, there is the issue of backward compatibility. This should definitely be something for the 1.0 version of ProjectTemplate because a lot of old scripts are going to fail.

@Hugovdberg Hugovdberg added this to the 1.0 milestone May 2, 2018
@KentonWhite KentonWhite added Affects interface and removed Under investigation Default label before an issue is classified as Bug/Feature/... labels May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants