Fix pmm deadlock #345
Merged
Fix pmm deadlock #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Optimally, we would refill the 4K frames while still holding the paging lock. However, this would need a new interface in pmm to allow refill without taking the paging lock again. |
|
there is still the deadlock issue where paging wants to get a frame but pmm is waiting for paging to map a new array. It looks like some kind of backoff is required. |
sparchatus
force-pushed
the
fix_pmm_deadlock
branch
from
1754bb4 to
aaa42b3
Compare
|
based on #344 Also fixes a (potential?) bug where |
sparchatus
force-pushed
the
fix_pmm_deadlock
branch
3 times, most recently
from
6521e20 to
d01825b
Compare
jcjgraf
previously approved these changes
Dec 4, 2024
wipawel
requested changes
Dec 4, 2024
wipawel
reviewed
Dec 30, 2024
wipawel
reviewed
Dec 30, 2024
sparchatus
force-pushed
the
fix_pmm_deadlock
branch
3 times, most recently
from
3b6e6ca to
dc3e94c
Compare
Signed-off-by: Sandro Rüegge <[email protected]>
sparchatus
force-pushed
the
fix_pmm_deadlock
branch
from
dc3e94c to
a6f23ee
Compare
wipawel
reviewed
Jan 28, 2025
1. paging gets exclusive pmm access during array refill. 2. pmm can call back into paging while holding the paging lock. 3. paging performs pmm refill if needed to ensure reserved frames. Signed-off-by: Sandro Rüegge <[email protected]>
sparchatus
force-pushed
the
fix_pmm_deadlock
branch
from
a6f23ee to
41767f5
Compare
wipawel
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An ugly first attempt to allow pmm frame array refill without deadlocking.
Intended to fix #343